mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 42956: Added variadic template for process::await.
Date Fri, 29 Jan 2016 21:18:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42956/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 9:18 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Changes
-------

GCC 4.8 has a bug using variadic templates with lambdas. This patch changes the previous one
to use a std::bind as a workaround for this bug.

http://binglongx.com/2014/04/25/workaround-for-gcc-bug-in-lambda-capturing-variadic-templates/


Bugs: MESOS-4551
    https://issues.apache.org/jira/browse/MESOS-4551


Repository: mesos


Description
-------

Previously, templates only existed to allow await to take either a
std::list of Futures, *exactly* 2 Futures as arguments, or *exactly* 3
Futures as arguments.

This commit removes the 2 and 3 argument templates and replaces them
with a variadic template that accepts an arbitrary number of Futures as
arguments.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/collect.hpp cd78b6c211c2e4ca2b1ebbe728cfc2dfad1a32c9


Diff: https://reviews.apache.org/r/42956/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message