mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 42939: Synchronized 'configuration.md' with the 'flags.cpp' files.
Date Fri, 29 Jan 2016 19:52:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42939/#review116994
-----------------------------------------------------------


Fix it, then Ship it!




My only question is about line wrapping. Doesn't seem to be consistent across the file. Is
the plan to wrap them all at 80 chars?


docs/configuration.md (line 1159)
<https://reviews.apache.org/r/42939/#comment178068>

    60s?


- Vinod Kone


On Jan. 29, 2016, 7:16 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42939/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 7:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
>     https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Synchronized 'configuration.md' with the 'flags.cpp' files.
> 
> Programatically generated HTML from the flag help strings and imported that text into
'configuration.md', thus synchronizing the documentation with the source code.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md b1ef1314eb9482a55015baa42b51d59b9f464a29 
> 
> Diff: https://reviews.apache.org/r/42939/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message