mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 42936: Edited flag help strings for style.
Date Fri, 29 Jan 2016 19:02:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42936/#review116982
-----------------------------------------------------------


Fix it, then Ship it!





src/master/main.cpp (line 126)
<https://reviews.apache.org/r/42936/#comment178049>

    s/this/This/



src/master/main.cpp (line 132)
<https://reviews.apache.org/r/42936/#comment178050>

    No need to explicitly specify the default?



src/slave/flags.cpp (line 66)
<https://reviews.apache.org/r/42936/#comment178058>

    backticks around `filepath` like you did below for `--modules`.



src/slave/flags.cpp (line 156)
<https://reviews.apache.org/r/42936/#comment178052>

    no back ticks around `rack:2`?



src/slave/flags.cpp (line 542)
<https://reviews.apache.org/r/42936/#comment178053>

    why is this a backtick?



src/slave/main.cpp (line 99)
<https://reviews.apache.org/r/42936/#comment178054>

    s/this/This/



src/slave/main.cpp (line 105)
<https://reviews.apache.org/r/42936/#comment178055>

    no need for "(default: 5050).


- Vinod Kone


On Jan. 29, 2016, 5:34 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42936/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4298
>     https://issues.apache.org/jira/browse/MESOS-4298
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Edited flag help strings for style.
> 
> Backticks were inserted where appropriate. This not only matches the convention in the
comments within our code, helps to enable the automatic generation of markdown-formatted documentation
from these help strings.
> 
> 
> Diffs
> -----
> 
>   src/logging/flags.cpp 978d735c8c8e9f3c46669cc633773f1ec1e1725d 
>   src/master/flags.cpp 6e7e17650341bc17c3af6f92fe83f974d4ce1efd 
>   src/master/main.cpp 0d5ac49121491152d8426cd764a1f1a0f37483ae 
>   src/slave/flags.cpp 75d7429a4e3e1d6259296257c0ace1ade365ac2b 
>   src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 
> 
> Diff: https://reviews.apache.org/r/42936/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message