mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42908: Fixed a flaky test in quota tests.
Date Fri, 29 Jan 2016 10:18:40 GMT


> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 957
> > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957>
> >
> >     Just check the code on `setQuota-->rescindOffer`, why not let allocator to
do the `rescindOffer`? It makes sense to let allocator to descide how many resources/offer
should be rescind.

If I understand you correctly, then it's because the allocator should manage offers. Currently,
the allocator allocates resources which are packed into offers by the master. Moving this
to allocator is quite a bit of refactoring, agreed? Do you propose to do this refactoring
as part of the patch? I'm not sure how schould I "fix" the issue.


> On Jan. 29, 2016, 8:42 a.m., Klaus Ma wrote:
> > src/tests/master_quota_tests.cpp, line 992
> > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line992>
> >
> >     ```
> >     driver.stop();
> >     driver.join();
> >     ```

Good catch, thanks!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42908/#review116908
-----------------------------------------------------------


On Jan. 28, 2016, 12:20 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42908/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 12:20 p.m.)
> 
> 
> Review request for mesos, Michael Park and Qian Zhang.
> 
> 
> Bugs: MESOS-4542
>     https://issues.apache.org/jira/browse/MESOS-4542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `AvailableResourcesAfterRescinding` test became flaky after we
> stopped offering unreserved resources beyond quota in
> https://reviews.apache.org/r/42835. Hence the allocator offers
> rescinded resources to `framework1` if an allocation happens before
> the test finishes, which violates the expectation that `framework1`
> receives resources only once. Since we do not really care about
> allocations in this test but rather about rescinded resources, the
> fix is just to ignore subsequent offers to `framework1`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 04efcf3362d3594e0ad8077793fa1f32536dd658 
> 
> Diff: https://reviews.apache.org/r/42908/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="MasterQuotaTest.AvailableResourcesAfterRescinding" ./bin/mesos-tests.sh
--gtest_shuffle --gtest_break_on_failure --gtest_repeat=5000`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message