mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.
Date Fri, 29 Jan 2016 10:13:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 10:13 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.


Changes
-------

Addressed comments. Aftr thinking more about it a bit more, copying the map actually makes
the most sense.


Repository: mesos


Description
-------

Previously, there was no way to extract the help strings from the help
process once they had been installed into it.  The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.

This commit adds API calls to the process::Help class to get at these
strings more easily.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d 
  3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be

  3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 

Diff: https://reviews.apache.org/r/42786/diff/


Testing
-------


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message