mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 42828: Updated ReviewBot to tee build output to a file.
Date Fri, 29 Jan 2016 02:01:15 GMT


> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote:
> > support/verify_reviews.py, line 140
> > <https://reviews.apache.org/r/42828/diff/1/?file=1221992#file1221992line140>
> >
> >     To avoid using tee, you could just do:
> >     
> >     "%s > %s 2>&1" % (command, build_output)
> 
> Vinod Kone wrote:
>     The above just outputs it to a file right? We want it to also output the contents
to the console (stdout) in real time.

Yes, that just outputs to the file.  If you want it to also go to the console, you do need
tee.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42828/#review116858
-----------------------------------------------------------


On Jan. 29, 2016, 1:15 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42828/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 1:15 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, Kevin Klues, and Michael Park.
> 
> 
> Bugs: MESOS-1469 and MESOS-4478
>     https://issues.apache.org/jira/browse/MESOS-1469
>     https://issues.apache.org/jira/browse/MESOS-4478
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated ReviewBot to tee build output to a file.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 
> 
> Diff: https://reviews.apache.org/r/42828/diff/
> 
> 
> Testing
> -------
> 
> ?  mesos git:(vinod/review_bot_tee_output) BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/
./support/verify_reviews.py vinod kone 1
> git rev-parse HEAD
> Checking if review: 41092 needs verification
> Latest diff timestamp: 2016-01-26 13:53:35
> Verifying review 41092
> Dependent review: https://reviews.apache.org/api/review-requests/41090/ 
> Dependent review: https://reviews.apache.org/api/review-requests/40951/ 
> Applying review 41092
> ./support/apply-review.sh -n -r 41092
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfile 'RUN apt-get update'
> + echo RUN apt-get update
> + append_dockerfile 'RUN apt-get -y install build-essential clang git maven autoconf
libtool'
> + echo RUN apt-get -y install build-essential clang git maven autoconf libtool
> + append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev
libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev'
> + echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev libsasl2-dev
libapr1-dev libsvn-dev libevent-dev libev-dev
> + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
> + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
> + append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
> + echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
> + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
> + echo ENV GTEST_OUTPUT xml:report.xml
> + case $COMPILER in
> + append_dockerfile 'ENV CC gcc'
> + echo ENV CC gcc
> + append_dockerfile 'ENV CXX g++'
> + echo ENV CXX g++
> + append_dockerfile 'WORKDIR mesos'
> + echo WORKDIR mesos
> + append_dockerfile 'COPY . /mesos/'
> + echo COPY . /mesos/
> + append_dockerfile 'RUN chown -R mesos /mesos'
> + echo RUN chown -R mesos /mesos
> + append_dockerfile 'USER mesos'
> + echo USER mesos
> + append_dockerfile 'CMD ./bootstrap && ./configure --verbose && DISTCHECK_CONFIGURE_FLAGS="--verbose"
GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck'
> + echo CMD ./bootstrap '&&' ./configure --verbose '&&' 'DISTCHECK_CONFIGURE_FLAGS="--verbose"'
GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck
> ++ date +%s
> + TAG=mesos-1453845969-21946
> + docker build --no-cache=true -t mesos-1453845969-21946 .
> ./support/docker_build.sh: line 117: docker: command not found
> Posting review: Bad patch!
> 
> Reviews applied: [40951, 41090, 41092]
> 
> Failed command: ['bash', '-c', 'set -o pipefail; export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export
COMPILER=gcc; ./support/docker_build.sh 2>&1 | tee build_41092']
> 
> Error:
>  ...<truncated>...
> + : ubuntu:14.04
> + : gcc
> + : --verbose
> +++ dirname ./support/docker_build.sh
> ++ cd ./support/..
> ++ pwd
> + MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
> + cd /Users/vinodkone/workspace/mesos
> + DOCKERFILE=Dockerfile
> + rm -f Dockerfile
> + case $OS in
> + append_dockerfile 'FROM ubuntu:14.04'
> + echo FROM ubuntu:14.04
> + append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
> + echo RUN rm -rf '/var/lib/apt/lists/*'
> + append_dockerfile 'RUN apt-get update'
> + echo RUN apt-get update
> + append_dockerfile 'RUN apt-get -y install build-essential clang git maven autoconf
libtool'
> + echo RUN apt-get -y install build-essential clang git maven autoconf libtool
> + append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev
libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev'
> + echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto libcurl4-nss-dev libsasl2-dev
libapr1-dev libsvn-dev libevent-dev libev-dev
> + append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
> + echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
> + append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
> + echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
> + append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
> + echo ENV GTEST_OUTPUT xml:report.xml
> + case $COMPILER in
> + append_dockerfile 'ENV CC gcc'
> + echo ENV CC gcc
> + append_dockerfile 'ENV CXX g++'
> + echo ENV CXX g++
> + append_dockerfile 'WORKDIR mesos'
> + echo WORKDIR mesos
> + append_dockerfile 'COPY . /mesos/'
> + echo COPY . /mesos/
> + append_dockerfile 'RUN chown -R mesos /mesos'
> + echo RUN chown -R mesos /mesos
> + append_dockerfile 'USER mesos'
> + echo USER mesos
> + append_dockerfile 'CMD ./bootstrap && ./configure --verbose && DISTCHECK_CONFIGURE_FLAGS="--verbose"
GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck'
> + echo CMD ./bootstrap '&&' ./configure --verbose '&&' 'DISTCHECK_CONFIGURE_FLAGS="--verbose"'
GLOG_v=1 MESOS_VERBOSE=1 make -j8 distcheck
> ++ date +%s
> + TAG=mesos-1453845969-21946
> + docker build --no-cache=true -t mesos-1453845969-21946 .
> ./support/docker_build.sh: line 117: docker: command not found
> 
> Full log: https://builds.apache.org/job/mesos-reviewbot/10980/console
> Error handling URL https://reviews.apache.org/api/review-requests/41092/reviews/: UNAUTHORIZED
({"stat": "fail", "err": {"msg": "The username or password was not correct", "code": 104}})
> git clean -fd
> git reset --hard c94f8eb71bcc912ccd6f4a9b793e2ab1928ae2f2
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message