mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <>
Subject Re: Review Request 42921: Fixed flaky MaxCompletedTasksPerFrameworkFlag test.
Date Thu, 28 Jan 2016 22:56:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 28, 2016, 10:56 p.m.)

Review request for mesos, Anand Mazumdar and Ben Mahler.


Updated based on comments, including a move of EnqueueOffers() into src/tests/mesos.hpp

Bugs: MESOS-4518

Repository: mesos

Description (updated)

Previously, this test was calling EXPECT_CALL() on
SchedulerDriver.resourceOffers() after the scheduler driver itself had
already been started. This resulted in flaky test results when offers
came in between schedDriver.start() and the EXPECT_CALL().

This commit fixes this test by moving the EXPECT_CALL() above the
schedDriver.start() call. However, because of the nature of this test,
this introduced a few complexities related to processing the incoming offers
in a loop later on. To allow this, we had to introduce a custom gmock
ACTION to enqueue offers in a process::Queue for later processing. This
ACTION is generally useful and has been placed in src/tests/mesos.hpp.

Diffs (updated)

  src/tests/master_tests.cpp ce6ce25a03cdb0883612fe40b20996ec2e50de40 
  src/tests/mesos.hpp 845b637c765b5b97568e9b3797b53814d2ab7782 



Tested locally on my mac, as well as with running support/ on a linux machine.


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message