mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42773: Added utility function to compute SHA512 digest.
Date Thu, 28 Jan 2016 21:43:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42773/#review116820
-----------------------------------------------------------




src/common/command_utils.hpp (line 68)
<https://reviews.apache.org/r/42773/#comment177925>

    s/alg/algorithm/
    
    (e.g., 512)



src/common/command_utils.hpp (line 71)
<https://reviews.apache.org/r/42773/#comment177924>

    s/alg/algorithm/



src/common/command_utils.cpp (line 169)
<https://reviews.apache.org/r/42773/#comment177926>

    hum, can you move the body of this method to shasum and call shasum in this function?
    
    ```
    Future<string> sha512(const Path& input)
    {
      return shasum("512", input);
    }
    ```


- Jie Yu


On Jan. 28, 2016, 6:44 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42773/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added utility function to compute SHA512 digest.
> 
> 
> Diffs
> -----
> 
>   src/common/command_utils.hpp bfab34571dd37980d9f99585e506eb015b499e28 
>   src/common/command_utils.cpp e9d782127f948e165f55d03a2b1bf47946cc7f4e 
>   src/tests/common/command_utils_tests.cpp 938f3995aacf74bac28ae11040de292aa328f1e5 
> 
> Diff: https://reviews.apache.org/r/42773/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message