mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 42672: Explicitly checked for the absence of allocation.
Date Thu, 28 Jan 2016 13:22:20 GMT


> On Jan. 23, 2016, 6:31 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1494
> > <https://reviews.apache.org/r/42672/diff/1/?file=1218656#file1218656line1494>
> >
> >     remove the blank line?

Which line do you mean?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42672/#review115975
-----------------------------------------------------------


On Jan. 22, 2016, 11:21 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42672/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the future for allocation is pending when there should be no
> allocations. Reduce the number of allocations triggered in the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp b1cb955b7eb1213c7ba4a9c5181545bb49154f06

> 
> Diff: https://reviews.apache.org/r/42672/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `make check`
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure
--gtest_shuffle`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message