mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
Date Thu, 28 Jan 2016 05:53:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42617/#review116719
-----------------------------------------------------------



Bad patch!

Reviews applied: [42615]

Failed command: ./support/apply-review.sh -n -r 42615

Error:
 ...<truncated>...
2016-01-28 05:53:38 URL:https://reviews.apache.org/r/42615/diff/raw/ [40106/40106] -> "42615.patch"
[1]
Total errors found: 0
Checking 54 files
Error: Commit message summary (the first line) must start with a capital letter.

Full log: https://builds.apache.org/job/mesos-reviewbot/11086/console

- Mesos ReviewBot


On Jan. 28, 2016, 12:56 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42617/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 12:56 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For example, avoid using `std::string` in a .cpp file that already does
> `using std::string`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6

>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp c5ffd017f83149a58a2dee8c87461cd06bb43bed

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4b7d1347f93261df7a7d512721146edca2703b34

>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3

>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55

> 
> Diff: https://reviews.apache.org/r/42617/diff/
> 
> 
> Testing
> -------
> 
> "make check" on OSX and Arch Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message