mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 42662: Added common command utils file.
Date Thu, 28 Jan 2016 02:26:44 GMT


> On Jan. 28, 2016, 12:52 a.m., Klaus Ma wrote:
> > src/tests/common/command_utils_tests.cpp, line 71
> > <https://reviews.apache.org/r/42662/diff/3/?file=1224150#file1224150line71>
> >
> >     Add a case for `tar/untar` failure.
> 
> Jojy Varghese wrote:
>     Will add a TODO.
> 
> Jie Yu wrote:
>     Maybe in a subsequent review. This patch is getting too big. @jojy, can you follow
up with that?

@jie will do.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42662/#review116665
-----------------------------------------------------------


On Jan. 28, 2016, 2:21 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42662/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4360
>     https://issues.apache.org/jira/browse/MESOS-4360
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This common file is a good place to add common command line utilities like tar,
> digests(sha256, sha512, etc). Currently this functionality is spread in the code
> base and this change would enable all those call sites to be replaced with a
> common code.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 47d0a7c0fe73b9297cd7dde6086b5e6e9e1f9e4e 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/common/command_utils.hpp PRE-CREATION 
>   src/common/command_utils.cpp PRE-CREATION 
>   src/tests/common/command_utils_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42662/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message