mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.
Date Thu, 28 Jan 2016 02:21:52 GMT


> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote:
> > src/tests/reservation_tests.cpp, line 253
> > <https://reviews.apache.org/r/40731/diff/6/?file=1199338#file1199338line253>
> >
> >     Could we check for 0.2 CPU here?
> 
> Avinash sridharan wrote:
>     This makes sense. Will modify the expectation, test and upload a change to reflect
this.

Modified the expectation on the final offer to check for the following reserved resources
in the final offer:
Resources reserved = Resources::parse("cpus:0.2;mem:512").get();


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review115138
-----------------------------------------------------------


On Jan. 28, 2016, 2:20 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixture to test the floating point precision during CPU resource allocation.
This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message