mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.
Date Thu, 28 Jan 2016 01:48:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42878/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 1:48 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4540
    https://issues.apache.org/jira/browse/MESOS-4540


Repository: mesos


Description
-------

Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy. The test relied on
the flags.cgroups_hierarchy to learn the net_cls hierarchy, instead it should be making a
call to cgroups::hierarchy to learn the hierarchy.


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp 7033ac1aa7ae8a3cf06d4f717580ce5a5afb648a 

Diff: https://reviews.apache.org/r/42878/diff/


Testing
-------

make and make check on Debian 8

Also ran the patch on CentOS 6 with Greg's help. He was using (boxcutter/centos66) vagrant
image to test this patch. (boxcutter/centos66) is where this test was failing.


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message