mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 42888: Used absolute paths for excludes paths in posix disk isolator.
Date Thu, 28 Jan 2016 01:14:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42888/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 1:14 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-4539
    https://issues.apache.org/jira/browse/MESOS-4539


Repository: mesos


Description
-------

Used absolute paths for excludes paths in posix disk isolator.

We should consistently use absolute paths for excludes paths in disk isolator, otherwise,
it's possible that some other paths under the directory matches the relative path, causing
incorrect disk usage being reported.


Diffs
-----

  src/slave/containerizer/mesos/isolators/posix/disk.hpp 5607c0f43084f491e4927f5c6ec283210aa5f355

  src/slave/containerizer/mesos/isolators/posix/disk.cpp d5bf8c10b9cfb360a7856144d59ce89060de5c99


Diff: https://reviews.apache.org/r/42888/diff/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message