mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
Date Thu, 28 Jan 2016 00:56:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42617/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 12:56 a.m.)


Review request for mesos and Michael Park.


Changes
-------

Rebase.


Repository: mesos


Description
-------

For example, avoid using `std::string` in a .cpp file that already does
`using std::string`.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6

  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b

  3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp c5ffd017f83149a58a2dee8c87461cd06bb43bed

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4b7d1347f93261df7a7d512721146edca2703b34

  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3

  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55


Diff: https://reviews.apache.org/r/42617/diff/


Testing
-------

"make check" on OSX and Arch Linux.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message