mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40553: Enable mesos tests installation.
Date Thu, 28 Jan 2016 00:42:44 GMT


> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote:
> > Looks mostly good to me. A few things were unclear to me:
> > 
> > * Would it make sense to add an `installcheck` target? My expectation for that would
be for it to invoke the installed tests and adding the (in)correct `builddir` magic to make
sure only stuff from `$PREFIX` is used.
> > * Why don't we install stout or libprocess tests? I would have thought that especially
the libprocess tests could be useful to diagnose low-level incompatibilites.
> 
> James Peach wrote:
>     I added an ``installcheck`` target.
>     
>     I didn't try to deal with stout or libprocess at the same time as this. Maybe it
makes sense to also install them, but the Mesos suite is going to give the most benefit. If
we want to go down that path, I'd like to do that as separate Jira tickets.

Nice. I've filed MESOS-4538 to activate `--enable-tests-install` for CI distcheck so these
tests don't rot away. I've also filed MESOS-4537 for installing stout and libprocess tests.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
-----------------------------------------------------------


On Jan. 27, 2016, 10:03 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
>     https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -----
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11

>   src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5

>   src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b

>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a

>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message