mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 42603: Added an http::Authenticator factory.
Date Wed, 27 Jan 2016 15:08:41 GMT


> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote:
> > src/master/master.cpp, line 535
> > <https://reviews.apache.org/r/42603/diff/2/?file=1219241#file1219241line535>
> >
> >     Good that you check for `NULL` here!
> >     
> >     The error message is fairly generic though. It would be great if it could give
some hints why this could have happened.

Well, that error is there because you don't get a better idea of what happened except that
you got null (otherwise it would have come in the error state).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42603/#review116582
-----------------------------------------------------------


On Jan. 25, 2016, 1:44 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42603/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan Schlicht, and Till
Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move the code required to instanciate instances of `process::http::authentication::Authenticator`
> in `src/master/main.cpp` to its own factory.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/authentication/http/authenticator.cpp PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682

>   src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906

>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352 
> 
> Diff: https://reviews.apache.org/r/42603/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message