mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 42603: Added an http::Authenticator factory.
Date Wed, 27 Jan 2016 14:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42603/#review116582
-----------------------------------------------------------




include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 38 - 39)
<https://reviews.apache.org/r/42603/#comment177613>

    Indent with 4 spaces.



src/authentication/http/authenticator.cpp (line 17)
<https://reviews.apache.org/r/42603/#comment177616>

    Should be included after `<sstream>`.



src/authentication/http/authenticator.cpp (line 52)
<https://reviews.apache.org/r/42603/#comment177615>

    s/is always/should be/



src/authentication/http/authenticator.cpp (lines 58 - 60)
<https://reviews.apache.org/r/42603/#comment177614>

    If multiple HTTP authenticators are not supported, why is `authenticators` supposed to
be a comma separated list of authenticators? Calling it `authenticator`, not splitting it
and expecting it to be a single authenticator would save us from these verifications.



src/master/master.cpp (line 502)
<https://reviews.apache.org/r/42603/#comment177624>

    Regarding my comment above: Now I see why `authenticators` is a comma-seperated list.
Because it's taking the `flags.http_authenticators`. I'd suggest to do the input validation
of these flags here and not in `Authenticator` and support only a single authenticator in
`Authenticator::create`.



src/master/master.cpp (line 507)
<https://reviews.apache.org/r/42603/#comment177618>

    Good that you check for `NULL` here!
    
    The error message is fairly generic though. It would be great if it could give some hints
why this could have happened.



src/master/master.cpp (line 511)
<https://reviews.apache.org/r/42603/#comment177620>

    IMHO this is already expressed in the comment above.



src/tests/http_authentication_tests.cpp (lines 82 - 85)
<https://reviews.apache.org/r/42603/#comment177621>

    ```cpp
    using process::http::authentication::Authenticator;
    using process::http::authentication::AuthenticationResult;
    using process::http::authentication::BasicAuthenticator;
    ```


- Jan Schlicht


On Jan. 25, 2016, 1:44 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42603/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan Schlicht, and Till
Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move the code required to instanciate instances of `process::http::authentication::Authenticator`
> in `src/master/main.cpp` to its own factory.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/authentication/http/authenticator.cpp PRE-CREATION 
>   src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682

>   src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906

>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352 
> 
> Diff: https://reviews.apache.org/r/42603/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message