mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.
Date Wed, 27 Jan 2016 03:04:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 3:04 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Address @bernd's comments.


Bugs: MESOS-4486
    https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
-------

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 

Diff: https://reviews.apache.org/r/42696/diff/


Testing (updated)
-------

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[       OK ] FetcherCacheTest.LocalUncached (2580 ms)
[       OK ] FetcherCacheTest.LocalCached (2524 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[       OK ] FetcherCacheTest.LocalUncached (873 ms)
[       OK ] FetcherCacheTest.LocalCached (1609 ms)
[       OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[       OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message