mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 42711: Included reserved resources in the role sorter for DRF.
Date Wed, 27 Jan 2016 02:12:14 GMT


> On Jan. 26, 2016, 3:05 p.m., Klaus Ma wrote:
> > I agree to include `reserved` reosurces in DRF; but just one question, why are we
going to have this patch now?
> 
> Qian Zhang wrote:
>     My understanding is, we are going to include reserved resources in the fairness calculation
the role sorter gradually in 2 phases.
>     Phase 1 (this patch): Only include the allocated portion of reserved resources.
>     Phase 2: Include the whole reserved resources regardless they are allocated or not.
>     I think that's why there is a TODO added in this patch.
> 
> Joris Van Remoortere wrote:
>     That's right!

Thanks Qian/Joris, that's what we are going to do; I'd like to know why we did not include
`reserved` resources before but include it by those patches. When I was drafting the idea
of MESOS-4303, it confused me that why we did not include `reserved` resources in DRF.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116296
-----------------------------------------------------------


On Jan. 27, 2016, 7:14 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 7:14 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 2d01034f43c3653f6233792ee6614fa311249e5c

>   src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae

>   src/tests/hierarchical_allocator_tests.cpp 7d5eed4dd4ad2d23e925d5cac73675752b016086

> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message