mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 42739: Accounted for reserved resources in the quota guarantee check.
Date Wed, 27 Jan 2016 00:14:18 GMT


> On Jan. 26, 2016, 8:06 a.m., Klaus Ma wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1153-1157
> > <https://reviews.apache.org/r/42739/diff/1/?file=1219786#file1219786line1153>
> >
> >     Can we use `flatten`? And add helper functions to clearup disk?

I think with the introduction of other types of `*Info` messages being added to `Resource`
and such, we'll have to figure out a long-term plan for how we want to address the various
types of resources. I saw that there are patches out to add helpers such as `flattenDisk`,
but we might want to move to using `removeDisk`, etc for example.

Within this context we also don't want to be creating new `Resources` instances, which `flatten`
does, since we're in a critical path in terms of perf implications.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42739/#review116315
-----------------------------------------------------------


On Jan. 26, 2016, 11:01 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42739/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 11:01 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp fa9939700ff44911b9d149a391677b3eb07577ae

>   src/tests/hierarchical_allocator_tests.cpp 7d5eed4dd4ad2d23e925d5cac73675752b016086

> 
> Diff: https://reviews.apache.org/r/42739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message