mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.
Date Tue, 26 Jan 2016 23:45:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 26, 2016, 3:45 p.m.)

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Changed back to the --help version (diff #1).

Summary (updated)

Fixed logrotate ContainerLogger on Centos6.

Bugs: MESOS-4515

Repository: mesos

Description (updated)

The `logrotate --version` flag is actually a very recent addition (3.9.1).  
The `--help` flag is more likely to be present on a supported system-with-logrotate, given
logrotate's usage of popopt.

Diffs (updated)

  src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 



make check (OSX & Centos6.7 & Centos7)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message