mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 42820: Relaxed the logrotate ContainerLogger's --logrotate_path validation.
Date Tue, 26 Jan 2016 23:01:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 26, 2016, 3:01 p.m.)

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Relax the check on `--logrotate_path` and changed to an Option.

Summary (updated)

Relaxed the logrotate ContainerLogger's --logrotate_path validation.

Bugs: MESOS-4515

Repository: mesos

Description (updated)

The `logrotate --version` flag is actually a very recent addition (3.9.1).  As such, most
`logrotate` binaries may not have the flag.

Changed the `--logrotate_path` validation to take an Option instead.
If specified, checks if the path is absolute and that it is executable.
If not specified, checks if logrotate exists.

Diffs (updated)

  src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
  src/slave/container_loggers/logrotate.cpp 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 


Testing (updated)

make check (OSX & Centos6.7 & Centos7)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message