mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.
Date Tue, 26 Jan 2016 22:48:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/#review116465
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/module_tests.cpp (line 167)
<https://reviews.apache.org/r/39781/#comment177489>

    Drop unnecessary parentheses.


- Benjamin Bannier


On Jan. 26, 2016, 8:24 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39781/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
>     https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update ModuleTest to not assume dynamic dlopen search.
> 
> 
> Diffs
> -----
> 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
> 
> Diff: https://reviews.apache.org/r/39781/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message