mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 42820: Fixed logrotate ContainerLogger on Centos6.
Date Tue, 26 Jan 2016 20:36:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.


Bugs: MESOS-4515
    https://issues.apache.org/jira/browse/MESOS-4515


Repository: mesos


Description
-------

The `logrotate --version` flag is actually a very recent addition (3.9.1).  The `--help` flag
is more likely to be present on a supported system-with-logrotate, given logrotate's usage
of popopt.


Diffs
-----

  src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 

Diff: https://reviews.apache.org/r/42820/diff/


Testing
-------

make check on OSX & Centos6


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message