mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 42754: Added support for labels to resource reservations.
Date Tue, 26 Jan 2016 18:34:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 6:34 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Improved unit tests per review comments.


Bugs: MESOS-4479
    https://issues.apache.org/jira/browse/MESOS-4479


Repository: mesos


Description
-------

Labels are free-form key-value pairs that can be used to associate
metadata with reserved resources.


Diffs (updated)
-----

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 
  include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
  include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
  src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
  src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
  src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
  src/tests/reservation_endpoints_tests.cpp 35c093567b07a11ca6eee85e2ff91894a460a7af 
  src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
  src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
  src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 

Diff: https://reviews.apache.org/r/42754/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message