mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.
Date Tue, 26 Jan 2016 17:22:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42803/#review116381
-----------------------------------------------------------


Ship it!




I wish clang had included `-Wsign-compare` in `-Wall`.

- Anand Mazumdar


On Jan. 26, 2016, 4:47 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42803/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Jan Schlicht.
> 
> 
> Bugs: MESOS-4513
>     https://issues.apache.org/jira/browse/MESOS-4513
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42803/diff/
> 
> 
> Testing
> -------
> 
> make check (gcc-4.9)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message