mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernd Mathiske <be...@mesosphere.io>
Subject Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.
Date Tue, 26 Jan 2016 09:18:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
-----------------------------------------------------------




src/tests/fetcher_cache_tests.cpp (line 196)
<https://reviews.apache.org/r/42696/#comment177375>

    Good idea, but then we need to set checkpointing to true for the recovery test below.



src/tests/fetcher_cache_tests.cpp (line 599)
<https://reviews.apache.org/r/42696/#comment177374>

    const



src/tests/fetcher_cache_tests.cpp (line 713)
<https://reviews.apache.org/r/42696/#comment177376>

    const


- Bernd Mathiske


On Jan. 24, 2016, 7:01 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
>     https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> -------
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [       OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [       OK ] FetcherCacheTest.LocalCached (2524 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [       OK ] FetcherCacheTest.LocalUncached (873 ms)
> [       OK ] FetcherCacheTest.LocalCached (1609 ms)
> [       OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [       OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message