mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39060: Create master detector per url & not per framework.
Date Tue, 26 Jan 2016 08:10:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/#review116314
-----------------------------------------------------------


Ship it!





src/sched/sched.cpp (line 167)
<https://reviews.apache.org/r/39060/#comment177359>

    i think we can call this `instance`, and name the internal static `singleton`?



src/sched/sched.cpp (line 1777)
<https://reviews.apache.org/r/39060/#comment177358>

    i don't think we need this extra new line.


- Joris Van Remoortere


On Jan. 5, 2016, 9:01 a.m., Mandeep Chadha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39060/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3595
>     https://issues.apache.org/jira/browse/MESOS-3595
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the number of framework created exceeds the lib process
> threads then during master failover the zookeeper updates can
> cause deadlock.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
> 
> Diff: https://reviews.apache.org/r/39060/diff/
> 
> 
> Testing
> -------
> 
> make check successful 
> Created 100 framework instances on a 24 CPU machine. Master failover detected by the
framework process and continue to work as expected.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message