mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 42751: Tweaked some resource test cases.
Date Tue, 26 Jan 2016 06:37:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review116289
-----------------------------------------------------------




src/tests/resources_tests.cpp (line 1603)
<https://reviews.apache.org/r/42751/#comment177313>

    Why do you update here?



src/tests/resources_tests.cpp (lines 1672 - 1673)
<https://reviews.apache.org/r/42751/#comment177314>

    Is this useful? I think that we already covered the `same` contain case in `EXPECT_TRUE((r1
+ r2).contains(r1 + r2));`


- Guangya Liu


On 一月 25, 2016, 10:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> -----------------------------------------------------------
> 
> (Updated 一月 25, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message