mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 42762: Improved performance of 'roles::validate'.
Date Tue, 26 Jan 2016 00:42:54 GMT


> On Jan. 26, 2016, 12:29 a.m., Neil Conway wrote:
> > src/common/roles.cpp, line 59
> > <https://reviews.apache.org/r/42762/diff/1/?file=1220834#file1220834line59>
> >
> >     Would `static constexpr` be better?
> 
> Benjamin Bannier wrote:
>     A `string` cannot be `constexpr` (could perform dynamic allocations).

D'oh, I'm sure I knew that. Thanks!


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42762/#review116232
-----------------------------------------------------------


On Jan. 26, 2016, 12:10 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42762/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This validation is used inside resource math which in turn is used
> heavily in the code base.
> The temporary string allocations caused a significant performance
> degradation in this critical path.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846 
> 
> Diff: https://reviews.apache.org/r/42762/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message