mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Review Request 42762: Improved performance of 'roles::validate'.
Date Tue, 26 Jan 2016 00:10:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42762/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

This validation is used inside resource math which in turn is used
heavily in the code base.
The temporary string allocations caused a significant performance
degradation in this critical path.


Diffs
-----

  src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846 

Diff: https://reviews.apache.org/r/42762/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message