mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.
Date Mon, 25 Jan 2016 23:22:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/#review116215
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42750]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Jan. 25, 2016, 10:49 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42750/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes the intent slightly clearer. In principle it should save a
> few cycles as well, but nothing significant. Also, clarify the name of
> a helper function.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07 
> 
> Diff: https://reviews.apache.org/r/42750/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message