mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cong Wang <xiyou.wangc...@gmail.com>
Subject Re: Review Request 41911: Added a test case for corrupt packets
Date Mon, 25 Jan 2016 22:05:25 GMT


> On Jan. 20, 2016, 6:12 p.m., Ian Downes wrote:
> > src/tests/containerizer/port_mapping_tests.cpp, line 1027
> > <https://reviews.apache.org/r/41911/diff/3/?file=1197167#file1197167line1027>
> >
> >     This function is doing a lot, both constructing the packet, opening a socket
and sending the packet. What about splitting this functionality? One function to construct,
another to open/send/close?

I tried, but both constructing the packet and sending the packet require almost same parameters,
so I am not sure if splitting in this way really improves anything here.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41911/#review115242
-----------------------------------------------------------


On Jan. 14, 2016, 8:03 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41911/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 8:03 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a test case to ensure no corrupt packet could be delivered to application.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01

> 
> Diff: https://reviews.apache.org/r/41911/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message