mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 42733: Added checks for presence of `ReservationInfo.principal`.
Date Mon, 25 Jan 2016 21:02:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42733/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Repository: mesos


Description
-------

Added checks for presence of `ReservationInfo.principal`.

The `ReservationInfo.principal` field was recently made `optional`. During the deprecation
cycle, requests that do not have the field set are invalidated and rejected. However, there
remain a couple places in the code that assume this field is always set. This patch uses `has_principal()`
before this field is accessed to ensure safety.


Diffs
-----

  src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
  src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
  src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 

Diff: https://reviews.apache.org/r/42733/diff/


Testing
-------

`make check`


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message