mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 42674: Replaced busybox with alpine in docker tests.
Date Mon, 25 Jan 2016 19:15:03 GMT


> On Jan. 23, 2016, 5:40 p.m., Jie Yu wrote:
> > Can you add more context in the description? Is that because there are too many
links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit
on links?
> > 
> > Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?
> 
> Guangya Liu wrote:
>     Per Tim's above comment, he only wants to fix the test cases which are pulling or
using the busybox image itself but not some reference, such as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_docker_tests.cpp#L93
etc
> 
> Bernd Mathiske wrote:
>     Why not use "alpine" in the reference-only cases as well?
> 
> Guangya Liu wrote:
>     Agree, it would be good to use "alpine" in all places to keep consistent.

I'm not inclined in changing the reference only cases, since it's a valid image to use and
we include other information from busybox in other cases to test parsing imaging, etc. We
switch to Alpine only because the actual filesystem image is causing problems with the docker
daemon in some configurations.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------


On Jan. 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755),
which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397

>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message