mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt
Date Mon, 25 Jan 2016 19:14:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42016/#review116146
-----------------------------------------------------------



Bad patch!

Reviews applied: [42018]

Failed command: ./support/apply-review.sh -n -r 42018

Error:
 ...<truncated>...
2016-01-25 19:14:49 URL:https://reviews.apache.org/r/42018/diff/raw/ [32008/32008] -> "42018.patch"
[1]
42018.patch:210: trailing whitespace.
 
42018.patch:214: trailing whitespace.
 
42018.patch:219: trailing whitespace.
 
42018.patch:223: trailing whitespace.
 
42018.patch:226: trailing whitespace.
 
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
3rdparty/zookeeper-3.4.5.patch:202: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:206: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:211: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:215: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:218: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:229: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:231: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:235: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:451: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:462: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:481: trailing whitespace.
+-        lock xadd dword ptr [eax], ecx; 
3rdparty/zookeeper-3.4.5.patch:482: trailing whitespace.
+-       lock xadd dword ptr [eax], ebx; 
3rdparty/zookeeper-3.4.5.patch:483: trailing whitespace.
+-        mov result, ecx; // result = ebx;        
3rdparty/zookeeper-3.4.5.patch:485: trailing whitespace.
+-     return result;    
3rdparty/zookeeper-3.4.5.patch:489: trailing whitespace.
+ 

Full log: https://builds.apache.org/job/mesos-reviewbot/11034/console

- Mesos ReviewBot


On Jan. 14, 2016, 12:43 a.m., M Lawindi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42016/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 12:43 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M Lawindi, and Yi
Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows:[2/2] Added zookeeper-3.4.5 to Mesos build
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa

>   3rdparty/patch.exe.manifest PRE-CREATION 
>   CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 
>   src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a 
> 
> Diff: https://reviews.apache.org/r/42016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> M Lawindi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message