mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.
Date Mon, 25 Jan 2016 14:35:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 3:35 p.m.)


Review request for mesos, Jan Schlicht and Till Toenshoff.


Changes
-------

Addressed comments and fix language issues in the commit_msg.


Bugs: MESOS-4329
    https://issues.apache.org/jira/browse/MESOS-4329


Repository: mesos


Description (updated)
-------

Waiting for the launch result is not enough as it is unrelated to
whether the launched container has terminated. If we do not wait for
that the global teardown might find it still running and fail the tests
(this can happen if we e.g., execute this test in isolation).

Also aline the name of the launch result to follow the canonical
scheme.


Diffs (updated)
-----

  src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead 

Diff: https://reviews.apache.org/r/42247/diff/


Testing
-------

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message