mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 42603: Added an http::Authenticator factory.
Date Mon, 25 Jan 2016 12:44:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42603/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 1:44 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jan Schlicht, and Till Toenshoff.


Changes
-------

Open up review.


Summary (updated)
-----------------

Added an http::Authenticator factory.


Repository: mesos


Description (updated)
-------

Move the code required to instanciate instances of `process::http::authentication::Authenticator`
in `src/master/main.cpp` to its own factory.


Diffs (updated)
-----

  include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/authentication/http/authenticator.cpp PRE-CREATION 
  src/authentication/http/basic_authenticator_factory.cpp 6eb1c5bd09b136d3bc20481ddcc65cb8bd153682

  src/examples/test_http_authenticator_module.cpp acf51a6deb8e7dc4ab6ac0cf70380ddbb1839906

  src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
  src/tests/http_authentication_tests.cpp bd622576973648e0dfeae1453a5ce631e4171352 

Diff: https://reviews.apache.org/r/42603/diff/


Testing (updated)
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message