mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.
Date Mon, 25 Jan 2016 02:16:36 GMT


> On Jan. 22, 2016, 5:37 a.m., Joseph Wu wrote:
> > General questions:
> > 
> > - Besides removing the possibility for overcommit, does this change give us anything
else?
> > - What happens if a master sends this modified `TaskInfo` to an agent that does
not have this chain of patches?
> > - Have you considered completely converting a `CommandInfo` to `ExecutorInfo`? 
If we do that, it may be possible to remove all the other places with special logic for command
tasks.

* It's more for evicting executor by master, there's several EPICs about sharing resources
between frameworks; and all of them need the feature to let resources owner get resouces back:
MESOS-4303 (reclaim/preemption in Mesos), "Optimsitic Offer Phase 2", "Borrow/Lend policy
on Quota" (draft idea in my mind)

* Good point! If did not get required info, e.g. `launch_dir`, we should keep the same behaviour
as before: let salve trace the executor info.

* Yes, I'm used to add `taskCommand` into `ExecutorInfo`; but when launch docker executor,
it need task info which is different with normal executor. In this patch, I'd like to focus
on moving the executor info into master.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41305/#review115703
-----------------------------------------------------------


On Jan. 19, 2016, 10:55 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41305/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 10:55 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris
Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1718
>     https://issues.apache.org/jira/browse/MESOS-1718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-1718: move getExecutorInfo from slave to master
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 2c3299bc1aaa0888f7e47a71965c56ada8ecc21f 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 
> 
> Diff: https://reviews.apache.org/r/41305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message