mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 41299: Allow DockerContainerizer log to console.
Date Sun, 24 Jan 2016 08:21:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review116013
-----------------------------------------------------------



I saw that all of the unit test are using `false` for `local`, can you please write some test
scenarios in `Testing Done` area?

- Guangya Liu


On 一月 23, 2016, 8:58 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4141
>     https://issues.apache.org/jira/browse/MESOS-4141
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow DockerContainerizer log to console.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp 5e7e55e2dd4e451bb754a6a888e9683760d95873

>   src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 
>   src/slave/containerizer/docker.cpp 40f6f0bc08d7d75ec9dc6494914793e3649820d0 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397

>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
> 
> Diff: https://reviews.apache.org/r/41299/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message