mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ezra Silvera <e...@il.ibm.com>
Subject Re: Review Request 42516: Add support for user-defined networks.
Date Sat, 23 Jan 2016 20:45:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/
-----------------------------------------------------------

(Updated Jan. 23, 2016, 8:45 p.m.)


Review request for mesos and TimothyIL TimothyIL.


Changes
-------

Verify that network_name is not empty


Bugs: MESOS-4369
    https://issues.apache.org/jira/browse/MESOS-4369


Repository: mesos


Description (updated)
-------

Signed-off-by: Ezra Silvera <ezra@il.ibm.com>


Diffs (updated)
-----

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
  include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
  src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 

Diff: https://reviews.apache.org/r/42516/diff/


Testing
-------

Using Swarm running on Mesos create a network with "docker  network create --driver=bridge
myNetwork"   and then create a container on that network:  "docker run --net=myNetwork...."


Thanks,

Ezra Silvera


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message