mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.
Date Sat, 23 Jan 2016 09:13:43 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 23, 2016, 1:13 a.m.)

Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan, Jie Yu, and Timothy


Fix an unsatisfied call to `process::reap`, which interferes with the next test that needs
to reap something.  `process::reap(0)` will end up doing the reap first.  The next reap will
instead return `None` instead of a status code.

Bugs: MESOS-4150

Repository: mesos


Adds two heavily-mocked tests for the Mesos containerizer and Docker containerizer. Each checks
that `ContainerLogger::recover` is called during `Containerizer::recover`.

Diffs (updated)

  src/tests/container_logger_tests.cpp c6b2e597517c74a55649287dc5ae5a3115f9a640 
  src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 



make (OSX & Centos7)

Tests are run in the next review.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message