mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 42674: Replaced busybox with alpine in docker tests.
Date Sat, 23 Jan 2016 02:17:04 GMT


> On 一月 23, 2016, 1 a.m., Guangya Liu wrote:
> > I saw that many test cases are using busybox, why only updating this one's image?
Is it possible to update all busybox to alpine? As the alpine was built around musl libc and
BusyBox. The image is only 5 MB in size and has access to a package repository that is much
more complete than other BusyBox based images.
> 
> Timothy Chen wrote:
>     Hi Guangya, there aren't any tests that I know of still using busybox. If you search
for busybox in the tests folder, they are just references and not actually pulling or using
the busybox image itself. The intention of this is to replace all busybox images to alpine.

What about this one https://github.com/apache/mesos/blob/master/src/examples/docker_no_executor_framework.cpp#L106
? This was not a unit test, but may also deserve a fix?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115959
-----------------------------------------------------------


On 一月 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755),
which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397

>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message