mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.
Date Fri, 22 Jan 2016 18:37:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42505/#review115896
-----------------------------------------------------------

Ship it!



src/common/resources.cpp (line 685)
<https://reviews.apache.org/r/42505/#comment176944>

    insert a blank line above?



src/common/resources.cpp (line 687)
<https://reviews.apache.org/r/42505/#comment176945>

    insert a blank line above?



src/v1/resources.cpp (line 685)
<https://reviews.apache.org/r/42505/#comment176946>

    Ditto.



src/v1/resources.cpp (line 687)
<https://reviews.apache.org/r/42505/#comment176947>

    Ditto.


- Jie Yu


On Jan. 22, 2016, 9:33 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42505/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 9:33 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Multiple Disk: Adjusted DiskInfo validation.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
>   src/master/validation.cpp 222bb3451c133844c42caad0567c1e98de6ba778 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/42505/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message