mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian Qiu" <qiuj...@cn.ibm.com>
Subject Re: Review Request 42440: Create a test macro to advance `Clock` for `Future`.
Date Fri, 22 Jan 2016 13:54:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42440/#review115842
-----------------------------------------------------------



3rdparty/libprocess/include/process/gtest.hpp (line 63)
<https://reviews.apache.org/r/42440/#comment176906>

    Maybe change this to advanceInterval?



3rdparty/libprocess/include/process/gtest.hpp (line 65)
<https://reviews.apache.org/r/42440/#comment176905>

    If the clock is paused outside, there is no need to pause here


- Jian Qiu


On 一月 17, 2016, 4:30 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42440/
> -----------------------------------------------------------
> 
> (Updated 一月 17, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jian Qiu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4418
>     https://issues.apache.org/jira/browse/MESOS-4418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create a test macro to advance `Clock` for `Future`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc

> 
> Diff: https://reviews.apache.org/r/42440/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message