mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 42637: Cleaned up formatting in allocator tests.
Date Fri, 22 Jan 2016 11:43:32 GMT


> On Jan. 22, 2016, 2:05 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 795
> > <https://reviews.apache.org/r/42637/diff/1/?file=1205241#file1205241line795>
> >
> >     I think that another clean up is also needed, as some tests are using `agent`
while some using `slave` as variable name, it is better to make consistent in this file.

I think we talked about a while ago. We agreed that this is sonething we should do in one
chunk, with a clear plan. Am I right that Diana from IBM is working on it?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42637/#review115762
-----------------------------------------------------------


On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42637/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 953712149bd951789beb29c72779c4ac65aa48dc

> 
> Diff: https://reviews.apache.org/r/42637/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message