mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 42633: Corrected a comment in the allocator.
Date Fri, 22 Jan 2016 11:40:34 GMT


> On Jan. 22, 2016, 8:16 a.m., Ben Mahler wrote:
> > Why did you make this change?
> 
> Qian Zhang wrote:
>     I think the main reason should be, after optimistic offer phase 1 is done, we will
have two types of revocable resource: usage slack (oversubscription resources) and allocation
slack.

Qian is spot on: we should not use oversubscribed and revocable interchangeably.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42633/#review115807
-----------------------------------------------------------


On Jan. 22, 2016, 1:24 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42633/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 1:24 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 18f77bcf596c2ee17b4e407fac4367b0c737ce82

> 
> Diff: https://reviews.apache.org/r/42633/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message