mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 42368: Added reservation endpoint test without authentication.
Date Fri, 22 Jan 2016 03:33:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42368/
-----------------------------------------------------------

(Updated Jan. 22, 2016, 3:33 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.


Changes
-------

Addressed comments; removed extraneous test cases.


Bugs: MESOS-4195
    https://issues.apache.org/jira/browse/MESOS-4195


Repository: mesos


Description
-------

Added reservation endpoint test without authentication.

Currently, dynamic reservation endpoints will not work when HTTP authentication is not set.
Currently, the authentication code will always return `None()` as the principal when authentication
is disabled. Furthermore, the `ReservationInfo.principal` field is being migrated to `optional`,
so dynamic reservations without a principal are invalidated by the master. This test checks
that these endpoints will fail as expected when HTTP authentication is disabled.


Diffs (updated)
-----

  src/tests/reservation_endpoints_tests.cpp a471f858061a694073afeebdf76be659da938d01 

Diff: https://reviews.apache.org/r/42368/diff/


Testing
-------

A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was added, and
make check was used to test. The new test was also run with `--gtest_repeat=1000 --gtest_break_on_failure=1`.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message