mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 42590: Removed reserved() API.
Date Fri, 22 Jan 2016 01:26:49 GMT


> On 一月 21, 2016, 6:37 p.m., Joseph Wu wrote:
> > include/mesos/v1/resources.hpp, line 227
> > <https://reviews.apache.org/r/42590/diff/1/?file=1204205#file1204205line227>
> >
> >     Instead of changing this to an Option, you should default to `"*"`.
> >     
> >     Otherwise, you end up with two arguments (`None()` and `"*"`) that give you
the same result.

I think the `"*"` will return empty resources, am I missing something? Please refer to https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L1426


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42590/#review115640
-----------------------------------------------------------


On 一月 21, 2016, 3:23 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42590/
> -----------------------------------------------------------
> 
> (Updated 一月 21, 2016, 3:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph
Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4447
>     https://issues.apache.org/jira/browse/MESOS-4447
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed reserved() API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
>   src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
>   src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/42590/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message